Skip to content

Change tag handling to support generation for Alpha API - #153

Closed
joshand wants to merge 9 commits into
meraki:masterfrom
joshand:master
Closed

Change tag handling to support generation for Alpha API#153
joshand wants to merge 9 commits into
meraki:masterfrom
joshand:master

Conversation

@joshand

@joshand joshand commented Mar 30, 2021

Copy link
Copy Markdown

In the current build script, we are currently limiting to first 10 tags, which excluded environmental. I've expanded this to 11 in order to stop the crash. This might result in correct environmental APIs, but I've not actually tested this.

@TKIPisalegacycipher TKIPisalegacycipher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 127 ends with "7 products" -- this can now be "8 products".

@joshand

joshand commented Mar 31, 2021

Copy link
Copy Markdown
Author

Re: meraki/api/batch/__init__.py

I had accidentally removed the meraki folder and had to restore it. When I did so, git converted the line breaks, so that's why this file is part of this commit.

warning: CRLF will be replaced by LF in meraki/api/batch/__init__.py.
The file will have its original line endings in your working directory

@TKIPisalegacycipher

Copy link
Copy Markdown
Collaborator

Thank you for submitting this. I tested these changes, and it breaks library generation for GA. We will not make these changes for the time being.

@joshand joshand reopened this Apr 1, 2021
@joshand

joshand commented Apr 1, 2021

Copy link
Copy Markdown
Author

To preserve library generation for GA/Beta branches, I moved this logic to an optional flag (-p ). So, to build for Alpha, you can use the following syntax:
python3 generate_library.py -o 608548899648439349 -v 1 -p 11

Using the regular generation command will continue to operate as usual for GA/Beta builds.
python3 generate_library.py -o 608548899648439349 -v 1

@joshand joshand changed the title Change number of tags we care about from 10->11 to support environmental Change tag handling to support generation for Alpha API Apr 1, 2021
@TKIPisalegacycipher

Copy link
Copy Markdown
Collaborator

Thanks @joshand ! This is a step in the right direction. However, there are other parts (like action batches) which would require additional logic. We will undertake this effort when the MT team is ready to GA their endpoints. In the meantime, it's hard to justify the additional work and testing that would be required to integrate this into the main branch. These commits make more sense in a separate development branch. Would you like to open a devel branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants